[BusyBox] ash - signal handling problem?
Jean Wolter
jw5 at os.inf.tu-dresden.de
Mon Feb 2 13:33:23 UTC 2004
"Vladimir N. Oleynik" <dzo at simtreas.ru> writes:
> Ohh. I again lost synced...
> Patch to current CVS version attached.
It seems to fix the problems we are seeing here. But there may be a
potential problem regarding the history handling. A command is added
to the history if it is not empty. This is checked via
#if MAX_HISTORY >= 1
/* Handle command history log */
/* cleanup may be saved current command line */
free(history[MAX_HISTORY]);
history[MAX_HISTORY] = 0;
if (len) {
/* add command to history ... */
So now we may add bogus commands to the history. Maybe the check
should be changed to if (len > 0) ?
Jean
More information about the busybox
mailing list