[BusyBox] Another modprobe patch

Glenn McGrath bug1 at iinet.net.au
Sat Aug 14 12:53:59 UTC 2004


On Wed, 11 Aug 2004 23:21:17 -0700
Mike Castle <dalgoda at ix.netcom.com> wrote:

> 
> It turns out the insmod does not need full path to work.  So, to make
> our lives easier, get rid of mod_strcmp and essentially use $(basename
> /path/to/module/foo.o .o).
> 
> This simplifies logic by having the code that strips the extention in
> only one place.  It also reduced the size of the .o file by 628 bytes,
> and memory usage by 15k, on my modules.dep which is 111k in size.

At this stage i think its better to maintain compatability with the
official modprobe, and keep the paths. There may be scritps that
parse the output of modprobe for some reason.

> I see one minor difference between busybox's modprobe and the real
> one:
> 
> If two modules are given to modprobe, the second one should be
> discarded. With busyboxes, it's added as an argument to the last
> insmod.

This should be fixed.


Glenn



More information about the busybox mailing list