[BusyBox] [PATCH RESEND] bug in find_real_root_device.c and code clean up

Erik Andersen andersen at codepoet.org
Tue Aug 3 00:13:02 UTC 2004


On Sun Aug 01, 2004 at 01:39:28PM +0000, Tito wrote:
> Hi to all,
> This patch is useful for:
> 1) remove an unused var from extern char *find_real_root_device_name(const char* name)
>     changing it to extern char *find_real_root_device_name(void).
> 2) fixes include/libbb.h, coreutils/df.c, util-linux/mount.c and  util-linux/umount.c accordingly.

Great.

> 3) fixes a bug, really a false positive,  in
> find_real_root_device_name() that happens if in the /dev
> directory exists a link named root (/dev/root) that should be
> skipped but is not. This affects applets like df that display
> wrong results like

Why would someone purposefully create a /dev/root device node?
And if they did purposefully create it, why not use it?
Is this a devfs thing?

 -Erik

--
Erik B. Andersen             http://codepoet-consulting.com/
--This message was written using 73% post-consumer electrons--



More information about the busybox mailing list