[BusyBox] bug from recursivce_action revision 1.12

Christian Grigis christian.grigis at smartdata.ch
Tue Apr 20 16:28:17 UTC 2004


Hello,  [sorry only saw this now]

On Wed, Apr 07, 2004 at 11:59:40AM -0600, Erik Andersen wrote:
> On Wed Apr 07, 2004 at 08:37:57PM +0400, Vladimir N. Oleynik wrote:
> > Hi.
> > 
> > Last changes (rev 1.12) to recursive_actions() by Christian Grigis
> > have problem.
> > Test for demonstrate:
> > 
> > $ mkdir aaa bbb ccc
> > $ su
> > # chown root bbb
> > # chmod 700 bbb
> > # exit
> > $ busybox chmod 777 -R .
> > ./bbb: Permision denied
> > 
> > But "./ccc" mode not changed. Previous variant works fine,
> > errors skiped and continued recursion.
> 
> I have reverted this change to libbb/recursive_action.c

Indeed, when I first looked at usages of recursive_action() it seemed
that stopping at an error was OK, but those commands do indeed ignore
errors and continue. Sorry about that.

-Christian


-- 
Christian Grigis                        |       SMARTDATA SA
Software Engineer                       |       PSE-B / EPFL
Phone: +41-21-693-84-98                 |       CH - 1015 Lausanne
mailto:christian.grigis at smartdata.ch    |       http://www.smartdata.ch



More information about the busybox mailing list