[BusyBox] find optimization

Vladimir N. Oleynik dzo at simtreas.ru
Tue Apr 20 07:57:47 UTC 2004


magicfox,

> Is it reasonable to overwrite the environment ?
> In this case with any number of path in line cmd.,
> I got a find size object from 3772 to 3672 bytes on a i386 ;-)

But your patch change show "ps"-like cmd usage string.

> --- find.c      Mon Mar 15 09:28:37 2004
> +++ find.c.opt  Mon Apr 19 17:46:45 2004
> @@ -265,15 +265,13 @@
>         }
> 
>         if (firstopt == 1) {
> -               if (! recursive_action(".", TRUE, dereference, FALSE, fileAction,
> +               argv[0][0] = '.';
> +               argv[0][1] = 0;
> +       }

Other metod:
          if (firstopt == 1) {
		static char dot_arg[]=".";

		argv[0] = dot_arg;
        }


PS: Please do not make "optimization" patchs for last prerelease project version!


--w
vodz




More information about the busybox mailing list