[BusyBox] patch to login, dmesg and obscure

Vladimir N. Oleynik dzo at simtreas.ru
Mon Jul 28 15:36:33 UTC 2003


Ronny,


>>wrapped have size(old) * 2 +1. This can`t overflow for rotate check.
>>
> 
> 
> 
> Are you realy sure?? Becuse some lines down ther's a
> 	strcat(wrapped, wrapped)
> instruction where the actual overflow occure.

Example:

old = "123" (4 bytes)
wrapped allocated = 3*2 + 1 = 7 bytes.
first initialisez only 4 bytes = "123"
after strcat resut is "123123" - 7 bytes.
Not overflow.


--w
vodz







More information about the busybox mailing list