[BusyBox] udhcp last diffs
Vladimir N. Oleynik
dzo at simtreas.ru
Tue Dec 16 13:43:21 UTC 2003
Russ,
> ===================================================================
> RCS file: /var/cvs/busybox/networking/udhcp/files.c,v
> retrieving revision 1.8
> retrieving revision 1.9
> diff -c -r1.8 -r1.9
> *** busybox/networking/udhcp/files.c 2003/12/16 01:42:18 1.8
> --- busybox/networking/udhcp/files.c 2003/12/16 02:29:11 1.9
> *** 167,173 ****
> {"min_lease", read_u32, &(server_config.min_lease), "60"},
> ! {"lease_file", read_str, &(server_config.lease_file), leases_file},
> {"pidfile", read_str, &(server_config.pidfile), "/var/run/udhcpd.pid"},
> {"notify_file", read_str, &(server_config.notify_file), ""},
> {"siaddr", read_ip, &(server_config.siaddr), "0.0.0.0"},
> {"min_lease", read_u32, &(server_config.min_lease), "60"},
> ! {"lease_file", read_str, &(server_config.lease_file), LEASES_FILE},
> {"pidfile", read_str, &(server_config.pidfile), "/var/run/udhcpd.pid"},
> why the complication of a static string rather than a define? gcc isn't dumb
Why?
leases_file declared as constant common string from leases.c
Your patch duplicate this string.
I don`t see problems from previous variant.
--w
vodz
More information about the busybox
mailing list