[BusyBox] [patch] Standalone shell not happy in -pre4.
Rob Landley
rob at landley.net
Mon Dec 15 11:37:18 UTC 2003
On Monday 15 December 2003 02:26, Vladimir N. Oleynik wrote:
> Rob,
>
> > Hi! Remember me complaining about this patch?
> >
> > http://www.busybox.net/cgi-bin/cvsweb/busybox/shell/ash.c?r1=1.65&r2=1.6
> >6
>
> Your idea exec() -> runappletbyname() is have principialy problems:
> ash is NOT REENTERANT. You must do many clearing and reseting
> internal ash structs.
> This patch is 5-minute for quick test for me and removed
> hard problem with reenterant only.
> But, I don`t support STANDALONE and ALWAYS_WIN options.
mjn3 explained to my why the original change had been made a year ago, and I'm
currently going through ash and cleaning it up a little bit. The hang it
experiences now if you run sh from sh is apparently not the hang it
experienced a year ago... It's dying in lookupvar this time. I'll trace it
down after I've gotten some sleep and dealt with Monday's appointments...
I'll let you know when I have a better fix. I'm working on it. Luckily, I
don't think I have to understand all 13,000 (!) lines of ASH for this, just
the init code. (And _most_ of the init code expects what's there to start
from zero and sets what it needs...)
> --w
> vodz
Rob
More information about the busybox
mailing list