[BusyBox] warning in uniq_main() !?

[Manuel Novoa III]

Hello,

On Wed, Aug 13, 2003 at 12:55:36PM +0200, Steven Scholz wrote:
> Philip Blundell wrote:
> 
> >On Wed, 2003-08-13 at 11:33, Steven Scholz wrote:
> >
> >>-       unsigned long dups, skip_fields, skip_chars, i;
> >>-       const char *s0, *e0, *s1, *e1, *input_filename;
> >>+       unsigned long dups=0, skip_fields, skip_chars, i;
> >>+       const char *s0, *e0=NULL, *s1, *e1, *input_filename;
> >
> >
> >Adding an initialiser to a local variable will probably increase the
> >code size.  Since that value is never actually used, any extra
> >instructions that are added this way would just be wasting space.
> 
> Hmm. So adding unessesary warnings would be better than adding one or two 
> bytes?

In some projects, adding unnecessary bytes to quiet meaningless warnings
would be reasonable.  But the goal of busybox code is minimal size.  So
I put the comment there to explain why the warnings were meaningless.

Manuel