[BusyBox] bug#1274: marked as done (top applet WmSize/WmRSS field width problem)

Sat Oct 26 04:47:42 UTC 2002

Your message dated Sat, 26 Oct 2002 04:22:48 -0600
with message-id <20021026102248.GF7483 at codepoet.org>
and subject line [BusyBox] bug#1274: top applet WmSize/WmRSS field width problem
has caused the attached bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Erik Andersen
(administrator, BusyBox.net bugs database)

--------------------------------------
Received: (at submit) by bugs.busybox.net; 5 Oct 2002 03:08:05 +0000
>From paw at si1.dod.gov.au  Fri Oct  4 21:08:05 2002
Received: by winder.codepoet.org (Postfix, from userid 104)
	id 7311E1575D0; Fri,  4 Oct 2002 21:08:04 -0600 (MDT)
Received: from cts04.webone.com.au (cts04.webone.com.au [210.9.240.37])
	by winder.codepoet.org (Postfix) with ESMTP id 5E4361575AB
	for <submit at bugs.busybox.net>; Fri,  4 Oct 2002 21:07:55 -0600 (MDT)
Received: from si1.dod.gov.au (dial-ctt06-50-85.webone.com.au [210.11.50.85])
	by cts04.webone.com.au (8.11.6/8.11.6) with ESMTP id g9537lM03637
	for <submit at bugs.busybox.net>; Sat, 5 Oct 2002 13:07:48 +1000
Message-ID: <3D9E576B.6010100 at si1.dod.gov.au>
Date: Sat, 05 Oct 2002 13:07:23 +1000
From: Paul Whittaker <paw at si1.dod.gov.au>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.0.0) Gecko/20020607
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: submit at bugs.busybox.net
Subject: top applet WmSize/WmRSS field width problem
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, hits=0.3 required=5.0
	tests=SPAM_PHRASE_00_01,USER_AGENT,USER_AGENT_MOZILLA_UA,
	      X_ACCEPT_LANG
	version=2.41
X-Spam-Level: 

Package: busybox
Version: 0.60.4
Severity: normal

The top applet was bombing out on me with a "can't skip whitespace" 
error when it encountered a 5-digit VmSize value for an X server 
process.  I fixed this by increasing the size and rss array sizes from 9 
to 12 and changing:

         /* skip whitespace in Wm* fields */
         if (id[0] == 'V' && id[1] == 'm') {
!               i = 3;
!               while (i--) {
!                       if (*buf == ' ') {
!                               buf++;
!                       } else {
!                               error_msg_and_die("ERROR status: can't 
skip whitespace for "
!                                       "'%s' field in:\n%s\n", id,buf);
!                       }
                 }
         }

to:

         /* skip whitespace in Wm* fields */
         if (id[0] == 'V' && id[1] == 'm') {
!               while (*buf == ' ') {
!                       buf++;
                 }
         }

This seems to work OK for me.  I'm baffled by the original code - 
presumably there's a good reason why this is so convoluted, but I can't 
see what it is.

---------------------------------------
Received: (at 1274-done) by bugs.busybox.net; 26 Oct 2002 10:22:51 +0000
>From andersen at codepoet.org  Sat Oct 26 04:22:51 2002
Received: by winder.codepoet.org (Postfix, from userid 1000)
	id B77F3157AF7; Sat, 26 Oct 2002 04:22:49 -0600 (MDT)
Date: Sat, 26 Oct 2002 04:22:48 -0600
From: Erik Andersen <andersen at codepoet.org>
To: Paul Whittaker <paw at si1.dod.gov.au>, 1274-done at bugs.busybox.net
Subject: Re: [BusyBox] bug#1274: top applet WmSize/WmRSS field width problem
Message-ID: <20021026102248.GF7483 at codepoet.org>
Reply-To: andersen at codepoet.org
References: <3D9E576B.6010100 at si1.dod.gov.au>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <3D9E576B.6010100 at si1.dod.gov.au>
User-Agent: Mutt/1.3.28i
X-Operating-System: Linux 2.4.19-rmk2, Rebel-NetWinder(Intel StrongARM 110 rev 3), 185.95 BogoMips
X-No-Junk-Mail: I do not want to get *any* junk mail.

On Sat Oct 05, 2002 at 01:07:23PM +1000, Paul Whittaker wrote:
> Package: busybox
> Version: 0.60.4
> Severity: normal
> 
> The top applet was bombing out on me with a "can't skip whitespace" 
> error when it encountered a 5-digit VmSize value for an X server 
> process.  I fixed this by increasing the size and rss array sizes from 9 

By backporting the updated top applet from unstable, this
problem has been fixed.

 -Erik

--
Erik B. Andersen             http://codepoet-consulting.com/
--This message was written using 73% post-consumer electrons--