[BusyBox] bug#1272: marked as done (gunzip -c problem)

Sat Oct 26 04:46:03 UTC 2002

Your message dated Sat, 26 Oct 2002 04:21:10 -0600
with message-id <20021026102109.GD7483 at codepoet.org>
and subject line [BusyBox] bug#1272: gunzip -c problem
has caused the attached bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Erik Andersen
(administrator, BusyBox.net bugs database)

--------------------------------------
Received: (at submit) by bugs.busybox.net; 30 Sep 2002 00:10:44 +0000
>From paul at lemoncube.com  Sun Sep 29 18:10:44 2002
Received: by winder.codepoet.org (Postfix, from userid 104)
	id AD7311575F1; Sun, 29 Sep 2002 18:10:43 -0600 (MDT)
Received: from www.fastmail.fm (fastmail.fm [209.61.183.86])
	by winder.codepoet.org (Postfix) with ESMTP id 7345B1575CE
	for <submit at bugs.busybox.net>; Sun, 29 Sep 2002 18:10:38 -0600 (MDT)
Received: from www.fastmail.fm (localhost [127.0.0.1])
	by localhost.localdomain (Postfix) with ESMTP id 07A246DBC0
	for <submit at bugs.busybox.net>; Sun, 29 Sep 2002 19:10:26 -0500 (CDT)
Received: from server2.fastmail.fm (server2.internal [10.202.2.133])
	by www.fastmail.fm (Postfix) with ESMTP id A91176DA6E
	for <submit at bugs.busybox.net>; Sun, 29 Sep 2002 19:10:25 -0500 (CDT)
Received: from server2.fastmail.fm (localhost [127.0.0.1])
	by localhost.localdomain (Postfix) with ESMTP id BC6F39370D
	for <submit at bugs.busybox.net>; Sun, 29 Sep 2002 19:10:24 -0500 (CDT)
Received: by server2.fastmail.fm (Postfix, from userid 99)
	id 6CA11936D9; Sun, 29 Sep 2002 19:10:24 -0500 (CDT)
Content-Disposition: inline
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="ISO-8859-1"
MIME-Version: 1.0
X-Mailer: MIME::Lite 1.2  (F2.6; T1.001; A1.48; B2.12; Q2.03)
Date: Mon, 30 Sep 2002 00:10:24 UT
From: "Paul Hayter" <paul at lemoncube.com>
To: submit at bugs.busybox.net
X-Epoch: 1033344624
X-Sasl-enc: XBABwxf5jOscYRgFTBUYXg
Subject: gunzip -c problem
Message-Id: <20020930001024.6CA11936D9 at server2.fastmail.fm>
X-Spam-Status: No, hits=0.0 required=5.0
	tests=none
	version=2.31
X-Spam-Level: 

Package: busybox
Version: 0.60.4
Severity: normal

gunzip -c tries to delete the source file instead of leaving it intact.
The problem code in gunzip.c is:

        if (delete_path && !(flags & gunzip_test)) {
                if (unlink(delete_path) < 0) {
                        error_msg_and_die("Couldn't remove %s",
                        delete_path);
                }
        }

The code should also check the gunzip_to_stdout flag. Here's my poor
hack to fix it:

        if (delete_path && !(flags & gunzip_test) && !(flags &
        gunzip_to_stdout)
) {
                if (unlink(delete_path) < 0) {
                        error_msg_and_die("Couldn't remove %s",
                        delete_path);
                }
        }

I am using Slackware 7.1 with glibc 2.1.3, with kernel 2.4.19

Cheers

Paul.
---------------------------------------
Received: (at 1272-done) by bugs.busybox.net; 26 Oct 2002 10:21:11 +0000
>From andersen at codepoet.org  Sat Oct 26 04:21:11 2002
Received: by winder.codepoet.org (Postfix, from userid 1000)
	id C24331579EC; Sat, 26 Oct 2002 04:21:10 -0600 (MDT)
Date: Sat, 26 Oct 2002 04:21:10 -0600
From: Erik Andersen <andersen at codepoet.org>
To: Paul Hayter <paul at lemoncube.com>, 1272-done at bugs.busybox.net
Subject: Re: [BusyBox] bug#1272: gunzip -c problem
Message-ID: <20021026102109.GD7483 at codepoet.org>
Reply-To: andersen at codepoet.org
References: <20020930001024.6CA11936D9 at server2.fastmail.fm>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20020930001024.6CA11936D9 at server2.fastmail.fm>
User-Agent: Mutt/1.3.28i
X-Operating-System: Linux 2.4.19-rmk2, Rebel-NetWinder(Intel StrongARM 110 rev 3), 185.95 BogoMips
X-No-Junk-Mail: I do not want to get *any* junk mail.

On Mon Sep 30, 2002 at 12:10:24AM +0000, Paul Hayter wrote:
> Package: busybox
> Version: 0.60.4
> Severity: normal
> 
> gunzip -c tries to delete the source file instead of leaving it intact.

Fixed.

 -Erik

--
Erik B. Andersen             http://codepoet-consulting.com/
--This message was written using 73% post-consumer electrons--