[BusyBox] [PATCH]: CONFIG_FEATURE_DEVPTS
Vladimir N. Oleynik
dzo at simtreas.ru
Mon Nov 4 11:00:04 UTC 2002
Pavel,
> > Hmm. I don`t like the dependence from your path:
> >
> > if [ "$CONFIG_FEATURE_DEVFS" = "y" ]; then
> > + define_bool $CONFIG_FEATURE_DEVPTS
>
> I'm sorry. I sent an old patch, the version before I fixed this bug.
> Thank you for noticing it! There should not be any "$" on that line:
>
> define_bool CONFIG_FEATURE_DEVPTS y
>
> > I don`t use dev filesystem but use pts filesystem.
>
> It should work properly now. It means that if devfs is enabled, always
> enable devpts. If devfs is disabled, ask user. Maybe if
> CONFIG_FEATURE_DEVPTS sounds wrong or confusing, you can rename it to
> CONFIG_FEATURE_UNIX98PTY or something like that to make it clear that the
> question is not about whether devpts is used, the question is whether Unix
> 98 pseudoterminals are used.
>
> Fixed patch is attached.
Is better ;)
I recalled, why option I don`t set as bb style config ;)
This option require having libc5 detect. Libc5 haven`t *pt() functions :(
I don`t know, such as make detect libc5 to configure grammatics.
--w
vodz
More information about the busybox
mailing list