[BusyBox] [PATCH]: CONFIG_FEATURE_DEVPTS

Pavel Roskin proski at gnu.org
Mon Nov 4 10:46:03 UTC 2002


Hello, Vladimir!

> Hmm. I don`t like the dependence from your path: 
> 
> if [ "$CONFIG_FEATURE_DEVFS" = "y" ]; then
> +  define_bool $CONFIG_FEATURE_DEVPTS   

I'm sorry.  I sent an old patch, the version before I fixed this bug.  
Thank you for noticing it!  There should not be any "$" on that line:

define_bool CONFIG_FEATURE_DEVPTS    y

> I don`t use dev filesystem but use pts filesystem.

It should work properly now.  It means that if devfs is enabled, always
enable devpts.  If devfs is disabled, ask user.  Maybe if
CONFIG_FEATURE_DEVPTS sounds wrong or confusing, you can rename it to
CONFIG_FEATURE_UNIX98PTY or something like that to make it clear that the
question is not about whether devpts is used, the question is whether Unix
98 pseudoterminals are used.

Fixed patch is attached.

-- 
Regards,
Pavel Roskin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: devpts-fixed.diff.gz
Type: application/x-gzip
Size: 827 bytes
Desc: 
Url : http://lists.busybox.net/pipermail/busybox/attachments/20021104/39579d4e/attachment.bin 


More information about the busybox mailing list