[BusyBox] ash (busybox) problem:"job control turned off"...

[Robert Griebl]

Am Montag, 10. Juni 2002 09:46 schrieben Sie:
> > > Robert:
> > > The current version login completely is bad.
> > > I do not have words, this utility in any mode could not fulfil
> >
> > BTW: Where is your problem with the 'const char *username' -- I don't see
> > any functional difference ?
>
> Your alteration login.c on all moments is completely wrong.
>
> 1) Your login_prompt() returned stack buffer! :00
Ok - forgot to make the buffer static

> 2) Your main() not reask login name after bad password
Ack

>
> It seems to me, that that who corrected this utility at all did not
> understand that does.
> What for have removed setpgrp(), have thought up any DEFAULT_USER though
> it not DEFAULT at all, and UNKNOW (bad),
> and DEFAULT_SHELL therefore in general to anything it is not necessary...
>
Maybe it's because it is monday, but IMHO this "comment" of yours is a cheek. 
I *started* this, because nobody else really wanted to implement the suid 
stuff over the last years (there was much discussion on the ml, but no code 
actually in the CVS).
So calling me a complete idiot ("... who corrected this utility at all did 
not understand...") is not a very nice way of saying "thanks for starting 
this, but hey, let's make it better".

So vodz: I appreciated your comments and ideas on the suid code, but _this_ 
is simply counter productive

And BTW: where do you see a setpgrp() in the tinylogin login.c ? - And for 
the rest: since I didn't find the source for a non-PAM linux login, I checked 
the original tinylogin version against the openbsd cvs version and took some 
code from there

Ok -- now let's get back to coding...

-- 
cu
Robert

--
Real programmers dont write documentation -
leave that to the maintenance people.