[BusyBox] bug#1229: marked as done (undefined junk in grep)

BusyBox.net bug Tracking System owner at busybox.net
Fri Apr 26 19:47:57 UTC 2002


Your message dated Fri, 26 Apr 2002 19:34:28 -0600
with message-id <20020427013428.GC6319 at codepoet.org>
and subject line Fixed
has caused the attached bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Erik Andersen
(administrator, BusyBox.net bugs database)

--------------------------------------
Received: (at submit) by bugs.busybox.net; 21 Feb 2002 14:40:42 +0000
>From richard at reika.demon.co.uk  Thu Feb 21 07:40:42 2002
Received: from anchor-post-33.mail.demon.net (anchor-post-33.mail.demon.net [194.217.242.91])
	by winder.codepoet.org (Postfix) with ESMTP id 73DA31575FE
	for <submit at bugs.busybox.net>; Thu, 21 Feb 2002 07:40:41 -0700 (MST)
Received: from reika.demon.co.uk ([193.237.154.55] helo=194.217.242.41)
	by anchor-post-33.mail.demon.net with esmtp (Exim 3.34 #1)
	id 16duOl-000G29-0X
	for submit at bugs.busybox.net; Thu, 21 Feb 2002 14:40:39 +0000
Received: (qmail 4735 invoked by uid 1000); 21 Feb 2002 14:38:01 -0000
Date: Thu, 21 Feb 2002 14:38:01 +0000
From: Richard Lightman <richard at reika.demon.co.uk>
To: submit at bugs.busybox.net
Subject: undefined junk in grep
Message-ID: <20020221143801.A3961 at urusai.localnet.rcl>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5i

Package: busybox
Version: 0.60.2
Severity: normal

Defining BB_FEATURE_GREP_EGREP_ALIAS but not BB_FEATURE_GREP_CONTEXT
gives a compile error:

gcc -Wall -Wshadow -Os -fomit-frame-pointer -D_GNU_SOURCE  -DBB_VER='"0.60.2"' -DBB_BT='"2002.02.21-14:32+0000"' -DUSE_SYSTEM_PWD_GRP  -I.  -c grep.c -o grep.o
grep.c: In function `grep_main':
grep.c:247: `junk' undeclared (first use in this function)
grep.c:247: (Each undeclared identifier is reported only once
grep.c:247: for each function it appears in.)
make: *** [grep.o] Error 1

The fix is trivial:

diff -urN busybox-0.60.2/grep.c busybox-0.60.2-grep/grep.c
--- busybox-0.60.2/grep.c       Tue Nov 20 00:23:19 2001
+++ busybox-0.60.2-grep/grep.c  Thu Feb 21 14:17:50 2002
@@ -234,7 +234,7 @@
 extern int grep_main(int argc, char **argv)
 {
        int opt;
-#ifdef BB_FEATURE_GREP_CONTEXT
+#if defined(BB_FEATURE_GREP_CONTEXT) || defined(BB_FEATURE_GREP_EGREP_ALIAS)
        char *junk;
 #endif
---------------------------------------
Received: (at 1229-done) by bugs.busybox.net; 27 Apr 2002 01:34:29 +0000
>From andersen at codepoet.org  Fri Apr 26 19:34:29 2002
Received: by winder.codepoet.org (Postfix, from userid 1000)
	id 1F4AC1578F1; Fri, 26 Apr 2002 19:34:29 -0600 (MDT)
Date: Fri, 26 Apr 2002 19:34:28 -0600
From: Erik Andersen <andersen at codepoet.org>
To: 1229-done at bugs.busybox.net
Subject: Fixed
Message-ID: <20020427013428.GC6319 at codepoet.org>
Reply-To: andersen at codepoet.org
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.3.28i
X-Operating-System: Linux 2.4.18-rmk1, Rebel-NetWinder(Intel StrongARM 110 rev 3), 185.95 BogoMips
X-No-Junk-Mail: I do not want to get *any* junk mail.

This was fixed a while ago.  Close the bug,

 -Erik

--
Erik B. Andersen             http://codepoet-consulting.com/
--This message was written using 73% post-consumer electrons--



More information about the busybox mailing list