[BusyBox] dpkg exit code fix

Glenn McGrath bug1 at optushome.com.au
Fri Sep 28 21:25:43 UTC 2001


On Fri, 28 Sep 2001 19:07:53 -0700
Stefan Soucek <ssoucek at coactive.com> wrote:

> Hi,
> 
> I've come across a minor bug in dpkg. It by default returns EXIT_FAILURE
> in dpkg_main(). This really should be EXIT_SUCCESS instead since there
are
> other exit points in the code, which exit with EXIT_FAILURE on error.
With
> the fix below dpkg's exit code seems to be sane. I have tested a couple
> of cases (-l -i -r) with good and bogus parameters.
> 
> Please apply this if you approve.
> 
> --- dpkg.c	2001/09/22 04:36:00	1.7
> +++ dpkg.c	2001/09/29 01:54:46	1.8
> @@ -1500,6 +1500,6 @@ extern int dpkg_main(int argc, char **ar
>  		}
>  	}
>  
> -	return(EXIT_FAILURE);
> +	return(EXIT_SUCCESS);
>  }
> 
> Thanks,
> -Stefan
> 

Looks good, will commit shortly.


Thanks

Glenn






More information about the busybox mailing list