[BusyBox] dpkg exit code fix

Stefan Soucek ssoucek at coactive.com
Fri Sep 28 20:08:12 UTC 2001


Hi,

I've come across a minor bug in dpkg. It by default returns EXIT_FAILURE
in dpkg_main(). This really should be EXIT_SUCCESS instead since there are
other exit points in the code, which exit with EXIT_FAILURE on error. With
the fix below dpkg's exit code seems to be sane. I have tested a couple
of cases (-l -i -r) with good and bogus parameters.

Please apply this if you approve.

--- dpkg.c	2001/09/22 04:36:00	1.7
+++ dpkg.c	2001/09/29 01:54:46	1.8
@@ -1500,6 +1500,6 @@ extern int dpkg_main(int argc, char **ar
 		}
 	}
 
-	return(EXIT_FAILURE);
+	return(EXIT_SUCCESS);
 }

Thanks,
-Stefan

--
Stefan Soucek, ssoucek at coactive.com
Coactive Networks, 28 Liberty Ship Way, Sausalito, CA 94965
Ph: (415) 289 7840, Fax: (415) 289 1320





More information about the busybox mailing list