[BusyBox] uname patch and questions

Glenn McGrath bug1 at optushome.com.au
Mon Nov 26 07:21:11 UTC 2001


This patch saves about 200 Bytes, minor changes are
  - uses getopt
  - use enum instead of 6 static ints (using #define probably would save
a fraction more)
  - use char instead of unsigned int
  - parse variable through function isntead using static global variable

and the questionable changes,
  - print an extra space prior to newline (avoid having to working if
its the last item)
  - dont attempt to display processor type (-p option), it always
printed "unknown" anyway becasue HAVE_SYSINFO and SI_ARCHITECTURE are
never defined (as far as i can see), and i dont see how -m and -p would
be different as -m prints my processor type "i686", i assume it does
similar on other arch's.

I'll commit it if i get the ok, but wasnt sure about the last two items.


Glenn
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: uname.diff
Url: http://lists.busybox.net/pipermail/busybox/attachments/20011126/6ba8a621/attachment.diff 


More information about the busybox mailing list