[BusyBox] Patch with clean and remove bugs to m* utils

[Erik Andersen]

On Wed Jan 31, 2001 at 09:11:44PM +0300, Vladimir N. Oleynik wrote:
> > As I was looking over your patch, I began thinking about
> > how often error_msg_and_die() and error_msg() are used.
> > Right now, these functions require a terminating \n.
> > These functions are used a _lot_ so we could save some
> > space by putting the \n into error_msg_and_die() and error_msg().
> > 
> >     $ grep error_msg *.c | grep -v perror_msg |wc
> >         346    2064   21721
> 
> Hmm, It my idea ~ 10 December: my first post in this maillist! :00

Hmm.  Ok, yes.  I see that post now.  I'm sorry -- I guess I was
so busy I missed that suggestion.  My appologies.

> >     --- utility.c   2001/01/30 18:03:11     1.194
> >     +++ utility.c   2001/01/31 17:45:07
> >     @@ -105,6 +105,7 @@ extern void error_msg(const char *s, ...
> >             va_start(p, s);
> >             verror_msg(s, p);
> >             va_end(p);
> >     +       write(fileno(stderr), "\n", 1);
> 
> putc('\n', stderr) not best? ;00

Hmm.  I expect that
    putc('\n', stderr);
or
    write(2, "\n", 1);
will produce equivalent code size.

 -Erik

--
Erik B. Andersen   email:  andersen at lineo.com
--This message was written using 73% post-consumer electrons--