[BusyBox] It's the preprocessor, stupid

Larry Doolittle ldoolitt at recycle.lbl.gov
Tue Jan 30 19:18:28 UTC 2001


EA> BTW, I asked Mark to look over his "static const int" patch
EA> to check for any other cases like this, and he didn't find
EA> any.

MW> But that doesn't mean they're not there... I'll keep my eye
MW> out for this sort of thing as I'm going through source doing
MW> other stuff.

Good!  This attitude is the sign of an old, wizened programmer,
who cares about code quality.

I only checked the rest of nfsmount.c, and didn't find any more
cases like that.  I hoped other people would help out on the
rest of the code.  Thanks for proving me right!

One more silly question: in ls.c, I see

#ifndef NAJOR
#define MAJOR(dev) (((dev)>>8)&0xff)
#define MINOR(dev) ((dev)&0xff)
#endif

It's been like that since at least 0.48.  Is "NAJOR" real, or
a typo?  If a typo, let's fix it.  If it's real, we should explain
why in a comment.

     - Larry





More information about the busybox mailing list