[BusyBox] Today's ash improvements

Aaron Lehmann aaronl at vitelus.com
Fri Aug 3 12:08:49 UTC 2001


On Fri, Aug 03, 2001 at 01:50:24PM -0400, David Edwards wrote:
> On Fri, Aug 03, 2001 at 09:54:07AM -0700, Aaron Lehmann wrote:
> > This patch contains three distinct size optimizations:
> > 
> > 1) is_digit() uses only one comparison now. ((c)>='0' && (c)<='9') was
> > replaced with ((unsigned)(c) - '0' <= 9). Neat trick, eh?
> 
> What about when c has an ascii value less than 0x30, like SPACE,!,",#,etc ?
> It seems that those characters will be classified as digits.

The "unsigned" is the key.





More information about the busybox mailing list