[BusyBox] 14 bugs on the wall/memory leak

Matt Kraai kraai at alumni.carnegiemellon.edu
Mon Apr 23 01:11:55 UTC 2001


On Sun, Apr 22, 2001 at 01:09:05PM +0400, Vladimir N. Oleynik wrote:
> Larry and Glenn,
>  
> > Cuts the number of strlen() operations per file from 4 to 1.
> > Better performance, and saves 47 bytes of text size, since
> > strcpy is inlined (at least in my build environment).
> > Add paranoia check to avoid buffer underrun.  By my count,
> > the original 14 (potential) bugs on the wall are down to 10.
> 
> I long see this and not found potential bug :-0
> 
> See new last patch, i think - this best. 
> Also, special for Glenn - new remove memory leaks.

I committed a variation on your ls.c patch.  As for untar.c, could
what is it supposed to be producing?  It still looks broken to me,
but I'm too lazy to try and figure out what it is trying to do.

Matt





More information about the busybox mailing list