[BusyBox] cleaning up gunzip

[Erik Andersen]

On Wed Sep 13, 2000 at 02:15:34PM +1100, Glenn McGrath wrote:
> Would it be ok if i did some cleanups of gunzip, things like
> 
> 1) grouping #include statments
> 
> 2) grouping the header comments from each of the files the gunzip was
> composed from.
> 
> 3) simplifying nested #define statments, here are some values mentioned
> in #if defined statements
> NO_STRING_H
> STDC_HEADERS
> NO_MEMMORY_H
> RETSIGTYPE
> INBUF_SIZE
> OUTBUF_SIZE
> SMALL_MEM
> DYN_ALLOC
> MAXSEG_64K
> 
> My thinking is that a lot of these would never have be modified so we
> could simplify things by just assuming one value and modifying code to
> only accomidate that. It would make it more readable.
> 
> 4) The other problem i see with gunzip is that it uses heaps of global
> variables, cleaning them up would make it more usable as well i think.
> 
> 
> Im not sure how important "cosmetic" changes are, thats really what im
> asking i guess.

I'm not sure if I ever responded to this or not.  I'd be ok with all of this.
I actually started on this at one point -- but then I got distracted.  I agree
that this stuff is currently a real mess...

 -Erik

--
Erik B. Andersen   email:  andersen at lineo.com
--This message was written using 73% post-consumer electrons--