[BusyBox] lsmod cleanup

Erik Andersen andersen at lineo.com
Tue Sep 12 16:23:03 UTC 2000


On Mon Sep 11, 2000 at 07:41:22PM -0700, Bryan Rittmeyer wrote:
> Hello,
> 
> I noticed a small output formatting bug in the latest CVS lsmod.c, which
> can result in ugly output if the module has a (foo) parameter:
> 
> ---
> /lib/modules # lsmod test
> Module                  Size  Used by
> test                     188   0 
>  (unused)/lib/modules # 
> ---
> 
> BB lsmod also inserts an extra space with the (foo) parameters,
> resulting in odd formatting:
> 
> ---
> bryan at squirt:~/src/busybox$ ./busybox lsmod
> Module                  Size  Used by
> ide-cd                 23636   0 
> cdrom                  27388   0 [ide-cd]
> isofs                  18288   0 
> minix                  23824   0 
> loop                    7872   0 
> agpgart                12724   0  (unused)
> 3c59x                  20448   1 
> ---
> 
> Note that the (unused) is indented one space further than the [ide-cd].
> 
> Here's my cleanup diff:


Mea culpa -- I made a mess of that one I guess.  Sorry about that.
Thanks, applied,

 -Erik

--
Erik B. Andersen   email:  andersen at lineo.com
--This message was written using 73% post-consumer electrons--





More information about the busybox mailing list