[BusyBox] bug#1068: dd exit error message patch
David Douthitt
ssrat at mailbag.com
Wed Oct 25 16:37:13 UTC 2000
On 25 Oct 2000, at 9:33, Erik Andersen wrote:
> On Wed Oct 25, 2000 at 08:06:21AM -0700, Matt Kraai wrote:
> > Would people please use EXIT_SUCCESS and EXIT_FAILURE, or 1 and 0,
> > rather than TRUE and FALSE as the values passed to exit?
> I've been thinking about this a bit. I think it may be time to simply so a
> global search and replace changing TRUE to OK and FALSE to ERROR (or some
> similar thing). That will be a first pass at fixing the problem.
Why not do this:
#define TRUE EXIT_SUCCESS
#define FALSE EXIT_FAILURE
I like TRUE and FALSE except when you are exiting....
Also, why not replace:
if (foo == TRUE)
with:
if (foo)
Is that less code?
--
David Douthitt
UNIX Systems Administrator
HP-UX, Linux, Unixware
ddouthitt at mennonite.minister.net
More information about the busybox
mailing list