[BusyBox] Re: BusyBox 0.43: tar.c and sh.c

Erik Andersen andersen at lineo.com
Wed Jun 21 15:24:55 UTC 2000


On Wed Jun 21, 2000 at 02:15:47PM +0200, Marius Groeger wrote:
> Hi Erik,
> 
> its me again (I'm the one who bothered you about the controlling tty issue).
> This time I'm hopefully more help, attached you can find two patches I'd
> like you to include in BusyBox.
> 
> 1. sh.c
>    
> The busybox sh wouldn't work with the popen() function, which invokes the
> shell with "sh -c command args...". I implemented the -c option to support
> this.


Hmm.  Ok, I will apply this.

> 2. tar.c 
> 2.a 
> 
> The source wouldn't compile correctly on a libc5 system because of an
> undifined MIN() macro
> 
> 2.b
> 
> When giving tar bad arguments, it would ask the user to try --help.
> Unfortunately, this option didn't exists at all. I took the liberty of
> adding a new option -h to print the usage, and changed the help text
> accordingly.
> 
> For the tar command, I'll probably come up with more patches. Eg. if one
> issues a "tar tvf", the unlink command will delete local files with the same
> name as in the tar archive due to an unconditional unlink().
> 

With GNU tar, "-h" means "don't dump symlinks; dump the files they point to".
So instead, I just fixed "--help" so it works (which is really what is wanted
here). 

 -Erik

--
Erik B. Andersen   email:  andersen at lineo.com
--This message was written using 73% post-consumer electrons--





More information about the busybox mailing list