[BusyBox] Ping fixes - sending for approval

Erik Andersen andersen at lineo.com
Wed Jun 7 20:01:07 UTC 2000


On Wed Jun 07, 2000 at 01:03:52PM -0400, Pavel Roskin wrote:
> Hello!
> 
> The patch for ping does the following:
> 
> Function ping() has a common prototype now
> All invocation of perror() now mention what ping was trying to do.
> Avoid messages like "ping wrote -1 chars"
> Support the "-s" option - length of the data
> "ping -c" doesn't crash anymore
> Added comments to some preprocessor directives
> 
> Regards,
> Pavel Roskin

All these changes look good.  Don't forget to update the docs
as well.  The docs, as you suspected, are hand rolled at the 
moment.  Some time in the future, autogenerating them might 
be a better thing...

 -Erik

--
Erik B. Andersen   email:  andersen at lineo.com
--This message was written using 73% post-consumer electrons--





More information about the busybox mailing list