[BusyBox] freeramdisk fix

Pavel Roskin pavel_roskin at geocities.com
Fri Jun 2 17:13:20 UTC 2000


Hello!

This patch
- eliminates the need to have a buffer and strcpy to it
- makes freeramdisk complain if it's given more than one argument (or
should we use for loop and change help?)

Regards,
Pavel Roskin

============================
diff -u -r1.1 freeramdisk.c
--- freeramdisk.c	2000/05/17 20:57:41	1.1
+++ freeramdisk.c	2000/06/02 17:01:30
@@ -43,21 +43,17 @@
 extern int
 freeramdisk_main(int argc, char **argv)
 {
-	char  rname[256] = "/dev/ram";
 	int   f;
 
-	if (argc < 2 || ( argv[1] && *argv[1] == '-')) {
+	if (argc != 2 || *argv[1] == '-') {
 		usage(freeramdisk_usage);
 	}
 
-	if (argc >1)
-		strcpy(rname, argv[1]);
-
-	if ((f = open(rname, O_RDWR)) == -1) {
-		fatalError( "freeramdisk: cannot open %s: %s\n", rname, strerror(errno));
+	if ((f = open(argv[1], O_RDWR)) == -1) {
+		fatalError( "freeramdisk: cannot open %s: %s\n", argv[1], strerror(errno));
 	}
 	if (ioctl(f, BLKFLSBUF) < 0) {
-		fatalError( "freeramdisk: failed ioctl on %s: %s\n", rname, strerror(errno));
+		fatalError( "freeramdisk: failed ioctl on %s: %s\n", argv[1], strerror(errno));
 	}
 	/* Don't bother closing.  Exit does
 	 * that, so we can save a few bytes */
============================







More information about the busybox mailing list