[BusyBox] syslogd bug

Erik Andersen andersen at lineo.com
Mon Dec 11 20:05:10 UTC 2000


On Mon Dec 11, 2000 at 12:58:55PM -0700, Matt Kraai wrote:
> Howdy,
> 
> The attached patch should prevent syslogd from segfaulting when it
> receives a message of unknown priority.  The array of names is
> terminated by a NULL, not by the empty string, and derefencing the
> NULL will cause a segfault.  Normally I'd commit this, but since we
> are approaching a release, I'll wait for word from on high.
[------------snip----------]
> -		if (*c_fac->c_name == '\0' || *c_pri->c_name == '\0')
> +		if (c_fac->c_name == NULL || c_pri->c_name == NULL)

By all means, please do commit this fix.  This certainly looks 
much more safe and sane, 

 -Erik

--
Erik B. Andersen   email:  andersen at lineo.com
--This message was written using 73% post-consumer electrons--





More information about the busybox mailing list