[BusyBox] insmod, bug #1018

Sébastien Côté scote1 at Matrox.COM
Fri Aug 18 15:16:13 UTC 2000


Hi,

I fixed a bug in Busybox 0.46 where the '\0' character wasn't copied so
insmod would fail to find the module (when you didn't put the absolute
path).  I'm not sure if this was fixed in CVS but it was a quick hack.

However, the bug report #1018 mentions that insmod can't load modules
even if you use an absolute path.  Everything seems to work fine here
(Busybox 0.46, kernel 2.2.16).  Am I just a lucky guy or what ?


-- 
Sébastien Côté
-------------- next part --------------
--- insmod.orig.c	Fri Aug 18 10:26:50 2000
+++ insmod.c	Fri Aug 18 11:02:14 2000
@@ -601,7 +601,7 @@
 			tmp++;
 		if (check_wildcard_match(tmp, fullName) == TRUE) {
 			/* Stop searching if we find a match */
-			memcpy(m_filename, fileName, strlen(fileName));
+			memcpy(m_filename, fileName, strlen(fileName)+1);
 			return (FALSE);
 		}
 	}


More information about the busybox mailing list