[git commit branch/1_32_stable] ash: remove a tentative TODO, it's a wrong idea

Denys Vlasenko vda.linux at googlemail.com
Fri Jan 1 13:30:58 UTC 2021


commit: https://git.busybox.net/busybox/commit/?id=4ac4f60942db83cb692fc94be28383f9c15a7379
branch: https://git.busybox.net/busybox/commit/?id=refs/heads/1_32_stable

Upstream tried it, and then reverted by:

    From: Herbert Xu <herbert at gondor.apana.org.au>
    Date: Tue, 26 May 2020 23:19:05 +1000
    parser: Fix double-backslash nl in old-style command sub

Signed-off-by: Denys Vlasenko <vda.linux at googlemail.com>
---
 shell/ash.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/shell/ash.c b/shell/ash.c
index ecb9b132b..ac25866ec 100644
--- a/shell/ash.c
+++ b/shell/ash.c
@@ -12811,7 +12811,7 @@ parsebackq: {
 				goto done;
 
 			case '\\':
-				pc = pgetc(); /* or pgetc_eatbnl()? why (example)? */
+				pc = pgetc(); /* not pgetc_eatbnl! */
 				if (pc != '\\' && pc != '`' && pc != '$'
 				 && (!synstack->dblquote || pc != '"')
 				) {


More information about the busybox-cvs mailing list