[git commit] uudecode: fix possible signed char bug
Denys Vlasenko
vda.linux at googlemail.com
Wed Oct 7 15:02:46 UTC 2020
commit: https://git.busybox.net/busybox/commit/?id=085f19cdffd653013b1483c08851ecc35cdd818e
branch: https://git.busybox.net/busybox/commit/?id=refs/heads/master
Signed-off-by: Denys Vlasenko <vda.linux at googlemail.com>
---
coreutils/uudecode.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/coreutils/uudecode.c b/coreutils/uudecode.c
index dc8ef5cca..5b2edd649 100644
--- a/coreutils/uudecode.c
+++ b/coreutils/uudecode.c
@@ -110,9 +110,7 @@ static void FAST_FUNC read_stduu(FILE *src_stream, FILE *dst_stream, int flags U
}
bb_simple_error_msg_and_die("short file");
}
-#endif
-#if ENABLE_UUDECODE
int uudecode_main(int argc, char **argv) MAIN_EXTERNALLY_VISIBLE;
int uudecode_main(int argc UNUSED_PARAM, char **argv)
{
@@ -202,10 +200,10 @@ int base64_main(int argc UNUSED_PARAM, char **argv)
*--argv = (char*)"-";
src_stream = xfopen_stdin(argv[0]);
if (opts) {
- read_base64(src_stream, stdout, /*flags:*/ (char)EOF);
+ read_base64(src_stream, stdout, /*flags:*/ (unsigned char)EOF);
} else {
enum {
- SRC_BUF_SIZE = 76/4*3, /* This *MUST* be a multiple of 3 */
+ SRC_BUF_SIZE = 76 / 4 * 3, /* this *MUST* be a multiple of 3 */
DST_BUF_SIZE = 4 * ((SRC_BUF_SIZE + 2) / 3),
};
char src_buf[SRC_BUF_SIZE];
More information about the busybox-cvs
mailing list