[Bug 10296] make allnoconfig enables CONFIG_FEATURE_SEAMLESS_GZ and CONFIG_LONG_OPTS

[bugzilla at busybox.net]

https://bugs.busybox.net/show_bug.cgi?id=10296

Alexei Colin <ac at alexeicolin.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ac at alexeicolin.com

--- Comment #5 from Alexei Colin <ac at alexeicolin.com> ---
(In reply to Denys Vlasenko from comment #4)
> > "make allnoconfig KCONFIG_ALLCONFIG=busybox.config"

> I don't even know what that is supposed to accomplish.

make allnoconfig KCONFIG_ALLCONFIG="configfile" is supposed to generate a
.config where a symbol is enabled if it or its dependee is enabled in
configfile. The code for this use case is in conf.c:

    case set_no:
        case set_mod:
        case set_yes:
        case set_random:
                name = getenv("KCONFIG_ALLCONFIG");
                if (name && !stat(name, &tmpstat)) {
                        conf_read_simple(name);
                        break;
                }

KCONFIG_ALLCONFIG allows overriding a default filename that would otherwise be
read (with the same purpose of setting symbols in .config):
{allno,allyes,...}.config.

0b1c62934215a08351a80977c7cf8e9346683a1e breaks this usecase.

This regression breaks miniconf [1,2,3,4] which assumes that if you pass a file
identical to .config to KCONFIG_ALLCONFIG, then the above command will generate
.config with the same contents (a noop).

Is there a way to fix the original issue without breaking KCONFIG_ALLCONFIG?
Thank you.

[1] http://landley.net/hg/aboriginal/file/c8293b3ab81f/more/miniconfig.sh
[2] http://landley.net/aboriginal/FAQ.html#dev_miniconfig
[3] https://lwn.net/Articles/161086/
[4] http://lists.uclibc.org/pipermail/uclibc/2007-March/017612.html

-- 
You are receiving this mail because:
You are on the CC list for the bug.