[git commit] ntpd: do not SEGV on "-p keyno:192.168.1.1", show --help instead

Denys Vlasenko vda.linux at googlemail.com
Sat Nov 24 23:42:56 UTC 2018


commit: https://git.busybox.net/busybox/commit/?id=0d18e5cab2159b55cb56962711d428246c197929
branch: https://git.busybox.net/busybox/commit/?id=refs/heads/master

Signed-off-by: Denys Vlasenko <vda.linux at googlemail.com>
---
 networking/ntpd.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/networking/ntpd.c b/networking/ntpd.c
index 4f8607244..041cac762 100644
--- a/networking/ntpd.c
+++ b/networking/ntpd.c
@@ -2539,6 +2539,7 @@ static NOINLINE void ntp_init(char **argv)
 				int key_id;
 				peer += 6;
 				end = strchr(peer, ':');
+				if (!end) bb_show_usage();
 				*end = '\0';
 				key_id = xatou_range(peer, 1, MAX_KEY_NUMBER);
 				*end = ':';


More information about the busybox-cvs mailing list