[Bug 10976] vi may lose ESCape key input

bugzilla at busybox.net bugzilla at busybox.net
Fri May 25 13:42:06 UTC 2018


https://bugs.busybox.net/show_bug.cgi?id=10976

--- Comment #4 from Mike Berger <mabnhdev at gmail.com> ---
I think silently dropping all buffered input when an invalid ESC sequence is
seen is a bug.

I think there are a few possible reactions.  I'll defer to more knowledgeable
folks as to which which is best.

  1. Silently drop the ESC and continue processing the following character as
if the ESC had not been received.
  2. Silently drop the ESC and the following invalid key.  Continue processing
as if the ESC-<bad> had not been received.
  3. Mimic the behavior of read_key() if no input had been buffered.  Return
the ESC, and continue processing the following character as if the ESC had not
been received.

Note that #3 would fix this particular bug without needing to do the
read_key()/read_key_raw() split, but I still think vi should not be calling a
function that may or may not process an ESC sequence.

-- 
You are receiving this mail because:
You are on the CC list for the bug.


More information about the busybox-cvs mailing list