[git commit] hush: add a FIXME comment
Denys Vlasenko
vda.linux at googlemail.com
Wed Mar 28 16:42:54 UTC 2018
commit: https://git.busybox.net/busybox/commit/?id=d1b845706df2aa819babe74cb0b9b15c13da6b16
branch: https://git.busybox.net/busybox/commit/?id=refs/heads/master
Signed-off-by: Denys Vlasenko <vda.linux at googlemail.com>
---
shell/hush.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/shell/hush.c b/shell/hush.c
index 012ec219f..e6dd1bc3d 100644
--- a/shell/hush.c
+++ b/shell/hush.c
@@ -8173,6 +8173,12 @@ static NOINLINE int run_pipe(struct pipe *pi)
rcode = 1; /* exitcode if redir failed */
if (setup_redirects(command, &squirrel) == 0) {
debug_printf_exec(": run_list\n");
+//FIXME: we need to pass squirrel down into run_list()
+//for SH_STANDALONE case, or else this construct:
+// { find /proc/self/fd; true; } >FILE; cmd2
+//has no way of closing saved fd#1 for "find",
+//and in SH_STANDALONE mode, "find" is not execed,
+//therefore CLOEXEC on saved fd does not help.
rcode = run_list(command->group) & 0xff;
}
restore_redirects(squirrel);
More information about the busybox-cvs
mailing list