[git commit] crond: code shrink

Denys Vlasenko vda.linux at googlemail.com
Sat Jul 8 22:08:13 UTC 2017


commit: https://git.busybox.net/busybox/commit/?id=d18b2000967cddd0b84091d90a914aec58025310
branch: https://git.busybox.net/busybox/commit/?id=refs/heads/master

function                                             old     new   delta
load_crontab                                         936     925     -11

Signed-off-by: Denys Vlasenko <vda.linux at googlemail.com>
---
 miscutils/crond.c | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/miscutils/crond.c b/miscutils/crond.c
index a472c9b..c0c8bef 100644
--- a/miscutils/crond.c
+++ b/miscutils/crond.c
@@ -512,13 +512,12 @@ static void load_crontab(const char *fileName)
 					if (strcmp(e->name, tokens[0] + 1) == 0) {
 						/*
 						 * tokens[1] is only the first word of command,
+						 * can'r use it.
 						 * find the entire command in unmodified string:
 						 */
-						tokens[5] = strstr(
-							skip_non_whitespace(skip_whitespace(parser->data)),
-							/* ^^^^ avoids mishandling e.g. "@daily aily PARAM" */
-							tokens[1]
-						);
+						tokens[5] = skip_whitespace(
+							skip_non_whitespace(
+							skip_whitespace(parser->data)));
 						if (e->tokens[0]) {
 							char *et = (char*)e->tokens;
 							/* minute is "0" for all specials */


More information about the busybox-cvs mailing list