[git commit] ntpd: print result of hostname resolution

Denys Vlasenko vda.linux at googlemail.com
Thu Jan 19 13:42:34 UTC 2017


commit: https://git.busybox.net/busybox/commit/?id=1bfc4b85a7915210936edc62ecf0d01a17751222
branch: https://git.busybox.net/busybox/commit/?id=refs/heads/master

This is particularly useful if hostname resolution is triggered by
host non-reachability: I saw this in real-life, without the message
it is not at all obvious that IP that we use for a specific host
has changed.

Signed-off-by: Denys Vlasenko <vda.linux at googlemail.com>
---
 networking/ntpd.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/networking/ntpd.c b/networking/ntpd.c
index bfd5705..5cc71ca 100644
--- a/networking/ntpd.c
+++ b/networking/ntpd.c
@@ -757,7 +757,7 @@ reset_peer_stats(peer_t *p, double offset)
 	 * and clear reachable bits, but this proved to be too agressive:
 	 * after step (tested with suspending laptop for ~30 secs),
 	 * this caused all previous data to be considered invalid,
-	 * making us needing to collect full ~8 datapoins per peer
+	 * making us needing to collect full ~8 datapoints per peer
 	 * after step in order to start trusting them.
 	 * In turn, this was making poll interval decrease even after
 	 * step was done. (Poll interval decreases already before step
@@ -800,6 +800,8 @@ resolve_peer_hostname(peer_t *p)
 		free(p->p_dotted);
 		p->p_lsa = lsa;
 		p->p_dotted = xmalloc_sockaddr2dotted_noport(&lsa->u.sa);
+		VERB1 if (strcmp(p->p_hostname, p->p_dotted) != 0)
+			bb_error_msg("'%s' is %s", p->p_hostname, p->p_dotted);
 	} else {
 		/* error message is emitted by host2sockaddr() */
 		set_next(p, HOSTNAME_INTERVAL);


More information about the busybox-cvs mailing list