[git commit] svc: remove superfluout INIT_G()

Denys Vlasenko vda.linux at googlemail.com
Sun Aug 6 19:29:51 UTC 2017


commit: https://git.busybox.net/busybox/commit/?id=7389662dbf54463222d66e555368e0151098ab38
branch: https://git.busybox.net/busybox/commit/?id=refs/heads/master

function                                             old     new   delta
sv                                                  1297    1296      -1
svc_main                                             162     145     -17

Signed-off-by: Denys Vlasenko <vda.linux at googlemail.com>
---
 runit/sv.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/runit/sv.c b/runit/sv.c
index 630f1f3..477c1ac 100644
--- a/runit/sv.c
+++ b/runit/sv.c
@@ -205,10 +205,8 @@ struct globals {
 #define islog        (G.islog       )
 #define INIT_G() do { \
 	setup_common_bufsiz(); \
-	/* need to zero out, we are NOEXEC */ \
-	rc = EXIT_SUCCESS; \
-	islog = 0; \
-	/* other fields need not be zero */ \
+	/* need to zero out, svc calls sv() repeatedly */ \
+	memset(&G, 0, sizeof(G)); \
 } while (0)
 
 
@@ -707,8 +705,6 @@ int svc_main(int argc UNUSED_PARAM, char **argv)
 	const char *optstring;
 	unsigned opts;
 
-	INIT_G();
-
 	optstring = "udopchaitkx";
 	opts = getopt32(argv, optstring);
 	argv += optind;


More information about the busybox-cvs mailing list