[git commit] ash: add a fixme comment at run_nofork_applet

Denys Vlasenko vda.linux at googlemail.com
Thu Aug 3 17:56:29 UTC 2017


commit: https://git.busybox.net/busybox/commit/?id=cfd392bea9f52539baae9be4833075e464075958
branch: https://git.busybox.net/busybox/commit/?id=refs/heads/master

Signed-off-by: Denys Vlasenko <vda.linux at googlemail.com>
---
 shell/ash.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/shell/ash.c b/shell/ash.c
index b285e3d..8c9f4ad 100644
--- a/shell/ash.c
+++ b/shell/ash.c
@@ -9918,11 +9918,13 @@ evalcommand(union node *cmd, int flags)
 		if (applet_no >= 0 && APPLET_IS_NOFORK(applet_no)) {
 			listsetvar(varlist.list, VEXPORT|VSTACK);
 			/* run <applet>_main() */
+//FIXME: do we need INT_OFF / INT_ON here?
+//wouldn't open files and allocations leak on ^C otherwise?
 			status = run_nofork_applet(applet_no, argv);
 			break;
 		}
 #endif
-		/* Can we avoid forking off? For example, very last command
+		/* Can we avoid forking? For example, very last command
 		 * in a script or a subshell does not need forking,
 		 * we can just exec it.
 		 */


More information about the busybox-cvs mailing list