[git commit] sh: do not print empty line at the end of "help" output

Denys Vlasenko vda.linux at googlemail.com
Sun Oct 2 16:45:09 UTC 2016


commit: https://git.busybox.net/busybox/commit/?id=ebedb9478d0d91d8aecf28531907e3a277450d0d
branch: https://git.busybox.net/busybox/commit/?id=refs/heads/master

It's pointless.

Signed-off-by: Denys Vlasenko <vda.linux at googlemail.com>
---
 shell/ash.c  | 2 +-
 shell/hush.c | 1 -
 2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/shell/ash.c b/shell/ash.c
index 421639e..f0dd70e 100644
--- a/shell/ash.c
+++ b/shell/ash.c
@@ -12848,7 +12848,7 @@ helpcmd(int argc UNUSED_PARAM, char **argv UNUSED_PARAM)
 		}
 	}
 # endif
-	out1fmt("\n\n");
+	newline_and_flush(stdout);
 	return EXIT_SUCCESS;
 }
 #endif
diff --git a/shell/hush.c b/shell/hush.c
index 8693d75..8054d1d 100644
--- a/shell/hush.c
+++ b/shell/hush.c
@@ -9005,7 +9005,6 @@ static int FAST_FUNC builtin_help(char **argv UNUSED_PARAM)
 		if (x->b_descr)
 			printf("%-10s%s\n", x->b_cmd, x->b_descr);
 	}
-	bb_putchar('\n');
 	return EXIT_SUCCESS;
 }
 #endif


More information about the busybox-cvs mailing list