[git commit] udhcpc: do not use -t NUM for counting "select" packets, use 3

Denys Vlasenko vda.linux at googlemail.com
Fri Mar 4 16:00:56 UTC 2016


commit: https://git.busybox.net/busybox/commit/?id=86d9f60f3acc4a5d755912003278267f8e6f3e89
branch: https://git.busybox.net/busybox/commit/?id=refs/heads/master

Otherwise, "-t 0" usage may end up sending them forever
if server does not respond.

function                                             old     new   delta
udhcpc_main                                         2846    2836     -10

Signed-off-by: Denys Vlasenko <vda.linux at googlemail.com>
---
 networking/udhcp/dhcpc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/networking/udhcp/dhcpc.c b/networking/udhcp/dhcpc.c
index 6c2b112..dfd5ca6 100644
--- a/networking/udhcp/dhcpc.c
+++ b/networking/udhcp/dhcpc.c
@@ -1501,7 +1501,7 @@ int udhcpc_main(int argc UNUSED_PARAM, char **argv)
 				packet_num = 0;
 				continue;
 			case REQUESTING:
-				if (!discover_retries || packet_num < discover_retries) {
+				if (packet_num < 3) {
 					/* send broadcast select packet */
 					send_select(xid, server_addr, requested_ip);
 					timeout = discover_timeout;


More information about the busybox-cvs mailing list