[git commit] zcip: fix wrong comparison of source IP with our IP

Denys Vlasenko vda.linux at googlemail.com
Sun Mar 22 16:59:34 UTC 2015


commit: http://git.busybox.net/busybox/commit/?id=4d15068d83054a9f82b3f8842706cd6deb401e25
branch: http://git.busybox.net/busybox/commit/?id=refs/heads/master

Commit "zcip: fix link-local IP conflict detection" has introduced
wrong comparsion of source IP with our IP. This leads to a new IP
being picked unnecessarily on every incoming ARP packet.

Signed-off-by: Vladislav Grishenko <themiron at mail.ru>
Signed-off-by: Denys Vlasenko <vda.linux at googlemail.com>
---
 networking/zcip.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/networking/zcip.c b/networking/zcip.c
index a3307c5..962ba2e 100644
--- a/networking/zcip.c
+++ b/networking/zcip.c
@@ -521,7 +521,7 @@ int zcip_main(int argc UNUSED_PARAM, char **argv)
 			target_ip_conflict = 0;
 
 			if (memcmp(&p.arp.arp_sha, &eth_addr, ETH_ALEN) != 0) {
-				if (memcmp(p.arp.arp_spa, &ip.s_addr, sizeof(struct in_addr))) {
+				if (memcmp(p.arp.arp_spa, &ip.s_addr, sizeof(struct in_addr)) == 0) {
 					/* A probe or reply with source_ip == chosen ip */
 					source_ip_conflict = 1;
 				}


More information about the busybox-cvs mailing list