[git commit] arping: fix iface name in error messages

Denys Vlasenko vda.linux at googlemail.com
Thu Mar 12 12:05:33 UTC 2015


commit: http://git.busybox.net/busybox/commit/?id=748fb60f274b1ba40aa6ed4c4582185aae8f68f7
branch: http://git.busybox.net/busybox/commit/?id=refs/heads/master

arping: interface eth0 not found: No such device
                  ^^^^

This is because error template is formed before parsing command line arguments,
so it always uses default interface name "eth0".

Signed-off-by: Alexander Korolkov <alexander.korolkov at gmail.com>
Signed-off-by: Denys Vlasenko <vda.linux at googlemail.com>
---
 networking/arping.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/networking/arping.c b/networking/arping.c
index a4421ed..dbfd75e 100644
--- a/networking/arping.c
+++ b/networking/arping.c
@@ -284,7 +284,6 @@ int arping_main(int argc UNUSED_PARAM, char **argv)
 	// Need to remove SUID_NEVER from applets.h for this to work
 	//xsetuid(getuid());
 
-	err_str = xasprintf("interface %s %%s", device);
 	{
 		unsigned opt;
 		char *str_timeout;
@@ -302,7 +301,7 @@ int arping_main(int argc UNUSED_PARAM, char **argv)
 	}
 
 	target = argv[optind];
-
+	err_str = xasprintf("interface %s %%s", device);
 	xfunc_error_retval = 2;
 
 	{


More information about the busybox-cvs mailing list