[git commit] i2cdetect: use break instead of goto in list_i2c_busses_and_exit()

Denys Vlasenko vda.linux at googlemail.com
Sun Jun 7 16:05:47 UTC 2015


commit: http://git.busybox.net/busybox/commit/?id=d90899206dd96b4c18064c18afc3b856382e64d4
branch: http://git.busybox.net/busybox/commit/?id=refs/heads/master

Since there are now more statements in the if block after the while loop
in list_i2c_busses_and_exit(), there's no need for a label.

Signed-off-by: Bartosz Golaszewski <bartekgola at gmail.com>
Signed-off-by: Denys Vlasenko <vda.linux at googlemail.com>
---
 miscutils/i2c_tools.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/miscutils/i2c_tools.c b/miscutils/i2c_tools.c
index 2f501cd..38d90ff 100644
--- a/miscutils/i2c_tools.c
+++ b/miscutils/i2c_tools.c
@@ -1226,12 +1226,11 @@ static void NORETURN list_i2c_busses_and_exit(void)
 						 i2cdev_path, de->d_name,
 						 subde->d_name);
 					fp = fopen(path, "r");
-					goto found;
+					break;
 				}
 			}
 		}
 
-found:
 		if (fp != NULL) {
 			/*
 			 * Get the rest of the info and display a line


More information about the busybox-cvs mailing list