[git commit] mpstat: code shrink

Denys Vlasenko vda.linux at googlemail.com
Mon Jan 5 17:39:23 UTC 2015


commit: http://git.busybox.net/busybox/commit/?id=1ec49732e2b477c45599f1a33953b4390e8c43e5
branch: http://git.busybox.net/busybox/commit/?id=refs/heads/master

function                                             old     new   delta
get_uptime                                           134     129      -5
get_irqs_from_stat                                   110     103      -7

Signed-off-by: Denys Vlasenko <vda.linux at googlemail.com>
---
 procps/mpstat.c |    8 ++------
 1 files changed, 2 insertions(+), 6 deletions(-)

diff --git a/procps/mpstat.c b/procps/mpstat.c
index c628d62..af3263d 100644
--- a/procps/mpstat.c
+++ b/procps/mpstat.c
@@ -522,9 +522,7 @@ static void get_irqs_from_stat(struct stats_irq *irq)
 	FILE *fp;
 	char buf[1024];
 
-	fp = fopen_for_read(PROCFS_STAT);
-	if (!fp)
-		return;
+	fp = xfopen_for_read(PROCFS_STAT);
 
 	while (fgets(buf, sizeof(buf), fp)) {
 		//bb_error_msg("/proc/stat:'%s'", buf);
@@ -644,9 +642,7 @@ static void get_uptime(data_t *uptime)
 	char buf[sizeof(long)*3 * 2 + 4]; /* enough for long.long */
 	unsigned long uptime_sec, decimal;
 
-	fp = fopen_for_read(PROCFS_UPTIME);
-	if (!fp)
-		return;
+	fp = xfopen_for_read(PROCFS_UPTIME);
 	if (fgets(buf, sizeof(buf), fp)) {
 		if (sscanf(buf, "%lu.%lu", &uptime_sec, &decimal) == 2) {
 			*uptime = (data_t)uptime_sec * G.hz + decimal * G.hz / 100;


More information about the busybox-cvs mailing list