[git commit] less: trivial code shrink

Denys Vlasenko vda.linux at googlemail.com
Mon Sep 22 19:17:24 UTC 2014


commit: http://git.busybox.net/busybox/commit/?id=865814a617cc2b197ef0ad12ee331a7a01d30e1a
branch: http://git.busybox.net/busybox/commit/?id=refs/heads/master

function                                             old     new   delta
read_lines                                           715     695     -20

Signed-off-by: Denys Vlasenko <vda.linux at googlemail.com>
---
 miscutils/less.c |    7 +++----
 1 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/miscutils/less.c b/miscutils/less.c
index 3016c5b..c5820d3 100644
--- a/miscutils/less.c
+++ b/miscutils/less.c
@@ -428,14 +428,13 @@ static void read_lines(void)
 		w -= 8;
 
 	p = current_line = ((char*)xmalloc(w + 4)) + 4;
-	max_fline += last_terminated;
 	if (!last_terminated) {
 		const char *cp = flines[max_fline];
-		strcpy(p, cp);
-		p += strlen(current_line);
-		free(MEMPTR(flines[max_fline]));
+		p = stpcpy(p, cp);
+		free(MEMPTR(cp));
 		/* last_line_pos is still valid from previous read_lines() */
 	} else {
+		max_fline++;
 		last_line_pos = 0;
 	}
 


More information about the busybox-cvs mailing list