[git commit] ash: add comment about failures in source builtin. No code changes.

Denys Vlasenko vda.linux at googlemail.com
Sun Mar 17 13:25:22 UTC 2013


commit: http://git.busybox.net/busybox/commit/?id=091f831424e8aa2052484ef07f0225f5405d086f
branch: http://git.busybox.net/busybox/commit/?id=refs/heads/master

Signed-off-by: Denys Vlasenko <vda.linux at googlemail.com>
---
 shell/ash.c |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/shell/ash.c b/shell/ash.c
index fbbdb06..edcb7c0 100644
--- a/shell/ash.c
+++ b/shell/ash.c
@@ -12258,6 +12258,9 @@ dotcmd(int argc, char **argv)
 	/* "false; . empty_file; echo $?" should print 0, not 1: */
 	exitstatus = 0;
 
+	/* This aborts if file isn't found, which is POSIXly correct.
+	 * bash returns exitcode 1 instead.
+	 */
 	fullname = find_dot_file(argv[1]);
 
 	argv += 2;
@@ -12269,6 +12272,9 @@ dotcmd(int argc, char **argv)
 		shellparam.p = argv;
 	};
 
+	/* This aborts if file can't be opened, which is POSIXly correct.
+	 * bash returns exitcode 1 instead.
+	 */
 	setinputfile(fullname, INPUT_PUSH_FILE);
 	commandname = fullname;
 	cmdloop(0);


More information about the busybox-cvs mailing list