[Bug 4267] DHCP Client: accepts ACK or NAK from other servers

bugzilla at busybox.net bugzilla at busybox.net
Wed Jan 25 22:56:17 UTC 2012


https://bugs.busybox.net/show_bug.cgi?id=4267

--- Comment #2 from busybox-bugs.20.masuefke at spamgourmet.com 2012-01-25 22:56:16 UTC ---
Created attachment 3998
  --> https://bugs.busybox.net/attachment.cgi?id=3998
ignore DHCP NAK from wrong servers

This bug is present in 1.1.3, too.
I am sorry the version I am reporting is so old, but this is the currently
running version on (older) FreeWRT (www.freewrt.org) embedded routers.

However, I am submitting my patch for 1.1.3, hoping it will somehow apply
against current versions, too.

Thoughts on the situation/the attached patch:
DHCP NAKs are ignorable if they do not have any Server ID. The right server
(with the right server id option) could answer with ACK any time later.
If no ACK is received in the following because the NAK was meant as a definite
NAK, the timeouts will catch the situation.

DHCP NAKs with the right server id are defnite. These reset the internal state
to INIT_SELECTING

IMHO this behaviour is compatible with RFC2131. On pg. 29 it says that "Server
identifier" is a MUST field for NAK packets. Thus, expecting a server
identifier should be ok.
-Martin

-- 
Configure bugmail: https://bugs.busybox.net/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.


More information about the busybox-cvs mailing list