[git commit] mdev: add a comment. no code changes

Denys Vlasenko vda.linux at googlemail.com
Mon Feb 6 00:00:00 UTC 2012


commit: http://git.busybox.net/busybox/commit/?id=638dbc34b3dd2a6e340a2370056913ed5770d196
branch: http://git.busybox.net/busybox/commit/?id=refs/heads/master

Signed-off-by: Denys Vlasenko <vda.linux at googlemail.com>
---
 util-linux/mdev.c |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)

diff --git a/util-linux/mdev.c b/util-linux/mdev.c
index 9765688..67de52d 100644
--- a/util-linux/mdev.c
+++ b/util-linux/mdev.c
@@ -565,8 +565,12 @@ static void make_device(char *path, int delete)
 				chown(node_name, rule->ugid.uid, rule->ugid.gid);
 			}
 			if (ENABLE_FEATURE_MDEV_RENAME && alias) {
-				if (aliaslink == '>')
+				if (aliaslink == '>') {
+//TODO: on devtmpfs, device_name already exists and symlink() fails.
+//End result is that instead of symlink, we have two nodes.
+//What should be done?
 					symlink(node_name, device_name);
+				}
 			}
 		}
 


More information about the busybox-cvs mailing list